Skip to content

Commit

Permalink
fix missing allocator in tensorfree (#197)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jutho authored Oct 30, 2024
1 parent 0135c8f commit dd55aa8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- x64
steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v1
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "TensorOperations"
uuid = "6aa20fa7-93e2-5fca-9bc0-fbd0db3c71a2"
authors = ["Lukas Devos <[email protected]>", "Maarten Van Damme <[email protected]>", "Jutho Haegeman <[email protected]>"]
version = "5.1.1"
version = "5.1.2"

[deps]
CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
Expand Down
5 changes: 3 additions & 2 deletions src/indexnotation/postprocessors.jl
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,11 @@ end
insertallocator(ex, allocator)
Insert the allocator argument into the tensor operation and allocation methods `tensoradd!`,
`tensortrace!`, `tensorcontract!`, `tensoralloc`, `tensoralloc_add`, and `tensoralloc_contract`.
`tensortrace!`, `tensorcontract!`, `tensoralloc`, `tensoralloc_add`, `tensoralloc_contract`
and `tensorfree!`.
"""
function insertallocator(ex, allocator)
return insertargument(ex, allocator,
(:tensoradd!, :tensortrace!, :tensorcontract!, :tensoralloc,
:tensoralloc_add, :tensoralloc_contract))
:tensoralloc_add, :tensoralloc_contract, :tensorfree!))
end

4 comments on commit dd55aa8

@lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented on dd55aa8 Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

Release Notes

Fixes a missing allocator in tensorfree!which led to memory leaks in the ManualAllocatorstrategy

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/118349

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v5.1.2 -m "<description of version>" dd55aa8cf5a0747c7875e7338400ac359f2a6083
git push origin v5.1.2

@lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented on dd55aa8 Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

Release notes:

Fixes a missing allocator in tensorfree!which led to memory leaks in the ManualAllocatorstrategy

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/118349

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v5.1.2 -m "<description of version>" dd55aa8cf5a0747c7875e7338400ac359f2a6083
git push origin v5.1.2

Please sign in to comment.