Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back a change that was present in older versions of Strided.jl, by normalizing the parent type of
StridedView
to only includeVector
.This main reason is this TensorOperations.jl PR which introduces some precompilation efforts, reporting a rather large amount of specializations from
Strided
.While there is definitely room for adding precompilation in this package as well, to further decrease the burden on TensorOperations itself, this seems like a rather simple change that has a huge impact on the precompilation times: my machine reports ~140 seconds before, but ~40 seconds after.
Alternatively, we could also consider just normalizing the types in
TensorOperations
itself, but this change seems reasonable to me.I'm not sure if this constitutes a breaking change though, given that fields are typically considered private I would say it isn't?