Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize parent array type #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Normalize parent array type #15

wants to merge 3 commits into from

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Feb 27, 2025

This PR brings back a change that was present in older versions of Strided.jl, by normalizing the parent type of StridedView to only include Vector.
This main reason is this TensorOperations.jl PR which introduces some precompilation efforts, reporting a rather large amount of specializations from Strided.
While there is definitely room for adding precompilation in this package as well, to further decrease the burden on TensorOperations itself, this seems like a rather simple change that has a huge impact on the precompilation times: my machine reports ~140 seconds before, but ~40 seconds after.
Alternatively, we could also consider just normalizing the types in TensorOperations itself, but this change seems reasonable to me.

I'm not sure if this constitutes a breaking change though, given that fields are typically considered private I would say it isn't?

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (27b1c09) to head (5025992).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   91.54%   91.66%   +0.12%     
==========================================
  Files           4        4              
  Lines         201      204       +3     
==========================================
+ Hits          184      187       +3     
  Misses         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant