Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes and doc updates #94

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Small fixes and doc updates #94

merged 2 commits into from
Oct 7, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Oct 7, 2024

No description provided.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.42%. Comparing base (52f1a78) to head (306aae0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   84.62%   82.42%   -2.21%     
==========================================
  Files          31       31              
  Lines        3318     3271      -47     
==========================================
- Hits         2808     2696     -112     
- Misses        510      575      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jutho
Copy link
Owner

Jutho commented Oct 7, 2024

From Lapack's dhseqr.f docstring:

*     INFO  (output) INTEGER
*             =  0:  successful exit
*           .LT. 0:  if INFO = -i, the i-th argument had an illegal
*                    value
*           .GT. 0:  if INFO = i, [DHSEQR](https://www.netlib.org/lapack/explore-3.1.1-html/dhseqr.f.html#DHSEQR.1) failed to compute all of
*                the eigenvalues.  Elements 1:ilo-1 and i+1:n of WR
*                and WI contain those eigenvalues which have been
*                successfully computed.  (Failures are rare.)

So we hit a rare failure 😄. I'll merge.

@Jutho Jutho merged commit 8bccac8 into master Oct 7, 2024
12 of 14 checks passed
@lkdvos lkdvos deleted the ld-docs branch October 7, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants