Skip to content

✨ Exclude Prereleases from Exclusive Matching #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025

Conversation

JustinGrote
Copy link
Owner

@JustinGrote JustinGrote commented Apr 12, 2025

Modifies behavior so that Module<2.0 does not match 2.0.0-alpha1 unless -StrictSemVer is specified
Fixes #107
image

@JustinGrote JustinGrote self-assigned this Apr 12, 2025
@JustinGrote
Copy link
Owner Author

@Jaykul can you please review and comment. Main concerns:

  • Since the -StrictSemVer is command wide, there's no way to specify some things you want strict and some you didn't. Maybe we need to add new spec syntax such as "!!" or something as well. Probably not worth the effort unless someone complains
  • I expanded the definition beyond major versions, so for instance Module<3.2.1 will exclude 3.2.1-alpha1, using the same logic as what we discussed. Let me know if you see any issues with that.

@JustinGrote JustinGrote merged commit bbaacc8 into main Apr 23, 2025
@JustinGrote JustinGrote deleted the feature/majorVersionExclude branch April 23, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behavior Change: Exclusive Major Version specifications should also exclude prereleases
2 participants