Add route('/send_message/<recipient>', methods=['GET', 'POST'])

[JustRomanVolkov]

No description provided.

[github-actions]

Here are some suggestions for improving the code in app/main/routes.py:

1. Add docstrings to the functions to explain their purpose and any parameters they accept. This will make the code more readable and help other developers understand its behavior.

Example:

@bp.route('/send_message/<recipient>', methods=['GET', 'POST'])
@login_required
def send_message(recipient):
    """
    Send a message to a specified recipient.

    Args:
        recipient (str): The username of the recipient user.

    Returns:
        The rendered template for sending a message.

    """
    ...

2. Use an SQLAlchemy query to get the user instead of using db.first_or_404(). You can pass the recipient parameter directly in the query instead of using an extra condition.

Instead of:

user = db.first_or_404(sa.select(User).where(User.username == recipient))

You can use:

user = User.query.filter_by(username=recipient).first_or_404()

3. Consider moving the message sending logic to a separate function. This can improve code organization and make the send_message function more focused on handling the request and rendering the template.

Example:

def send_message(recipient, form):
    user = User.query.filter_by(username=recipient).first_or_404()
    msg = Message(author=current_user, recipient=user, body=form.message.data)
    db.session.add(msg)
    user.add_notification('unread_message_count', user.unread_message_count())
    db.session.commit()
    flash(_('Your message has been sent.'))
    return redirect(url_for('main.user', username=recipient))


@bp.route('/send_message/<recipient>', methods=['GET', 'POST'])
@login_required
def send_message_route(recipient):
    form = MessageForm()
    if form.validate_on_submit():
        return send_message(recipient, form)
    return render_template('send_message.html', title=_('Send Message'), form=form, recipient=recipient)

4. Consider using consistent indentation. The line next_url=next_url, prev_url=prev_url) in the search() function has a different indentation level than the rest of the code in the function.

5. It's a good practice to validate the existence of the recipient user before rendering the send_message template. If the user does not exist, you can display an appropriate error message.

Example:

def send_message_route(recipient):
    user = User.query.filter_by(username=recipient).first()
    if not user:
        flash(_('Recipient user not found'))
        return redirect(url_for('main.search'))
    form = MessageForm()
    if form.validate_on_submit():
        return send_message(recipient, form)
    return render_template('send_message.html', title=_('Send Message'), form=form, recipient=recipient)

By implementing these suggestions, the code will be more readable, maintainable, and follow best practices.