Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add routes: #43

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Add routes: #43

merged 1 commit into from
Feb 15, 2024

Conversation

JustRomanVolkov
Copy link
Owner

/messages
/notifications

/messages
/notifications
Copy link

  • In the routes.py file, on lines 18-19, a MessageForm is imported but not used anywhere in the code. It should either be removed or used in a relevant function.

  • On lines 28-29, the Message and Notification models are imported but not used anywhere in the code. They should either be removed or used in relevant functions.

  • On line 34, there is a comment in a non-English language. It would be better to have comments in English for better readability and maintainability of the code.

  • On lines 40-41, the datetime module from the datetime package and timezone module from the datetime package are imported but not used anywhere in the code. They should be removed to avoid unnecessary imports.

  • On line 52, there is a reference to db.paginate which doesn't seem to be a recognized method. It should be replaced with the correct method for pagination, depending on the database backend being used in the application.

  • On lines 57-63, the next_url and prev_url variables are assigned values based on whether the messages object has a next or previous page. However, these variables are not used anywhere in the template. If they are not needed, they can be removed to avoid confusion.

  • On lines 69-75, the since parameter is used to filter notifications. However, it is not clear where this parameter is coming from or how it is intended to be used. Some additional context or explanation would be helpful to understand the purpose of this endpoint.

@JustRomanVolkov JustRomanVolkov merged commit 0a65a94 into master Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant