Rename EFNYC -> EVICTIONFREE everywhere with proper case #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaratrilling
commented
Mar 25, 2021
toolness
reviewed
Mar 30, 2021
There was a problem hiding this comment.
This is looking good, and I appreciate your anticipation of potential edge cases! As you can see from the other comments I've posted, though, this might not actually be as straightforward a task as I imagined it'd be... let's talk about this more when you get back.
|
Blocked on backend onboarding from Atul + pairing (week of Apr 12) |
|
@toolness to take another look and flag which renamings won't have downstream consequences. |
|
Hmm, yeah, I looked at this again and I think it might be easiest to just leave everything as-is for now, and instead file a different PR that refactors things to dynamically get the EFNY URL from the site configuration later. Sorry about that! |
|
No problem! Gonna close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuant to bug #1918 , rename EFNYC -> evictionfree. There may be one place where we want to leave it in place - if we care about the google analytics tracker name being the same.