-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Memgraph integration SDK CLI #941
base: main
Are you sure you want to change the base?
Conversation
## Installation | ||
|
||
This command assumes you have three additional values stored in your local .env | ||
file: NEO4J_URI NEO4J_USER NEO4J_PASSWORD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these .env value names correct? I think you've declared MEMGRAPH specific ones elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, I fixed the value names in the newest commit
getToTypeLabel, | ||
} from './memgraphUtilities'; | ||
|
||
import * as memgraph from 'neo4j-driver'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Memgraph use the same Javascript driver as Neo4j? If so, would we be able to share some of the same codebase with our existing Neo4j graph storage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Memgraph is compatible with Neo4j and uses the same JS driver so you can share some of the codebase. I separated everything to preserve the integrity of your code, but feel free to make the necessary changes
Thanks so much for the contribution! I left a few comments. My biggest question is whether or not we can share some code with our existing Neo4j functions to make long term support easier. Also, it looks like some checks might be failing due to formatting issues. We have an included command to update everything to our formatting standards if you run Thanks! |
Added integration for Memgraph related to the Starbase PR: JupiterOne/starbase#99