-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bocchi #1078
Merged
Merged
Bocchi #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- will now create the correct type of index file for a step based on the type of step it should be. - renamed some template folders.
…nto IP-SPRINT-bocchi
…into IP-SPRINT-bocchi
- Add functionality to copy over the base service client - create the client template - update types
Bocchi updates
RonaldEAM
reviewed
May 13, 2024
packages/integration-sdk-cli/src/bocchi/templates/top-level/src/client.ts.hbs
Show resolved
Hide resolved
VDubber
reviewed
May 15, 2024
VDubber
reviewed
May 15, 2024
VDubber
previously approved these changes
May 17, 2024
VDubber
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the files in this PR are .hbs files, and I'm not sure how familiar people are with those. I think the most important things for review are the READMEs (top-level one and the ones in
/bocchi/docs
, as well as the following .hbs files:/bocchi/templates/partials/directRelationships.hbs
,/bocchi/templates/partials/mappedRelationships.hbs
,/bocchi/templates/steps/child-singleton.ts.hbs
,/bocchi/templates/steps/fetch-child-entities.ts.hbs
,/bocchi/templates/steps/fetch-entities.ts.hbs
,/bocchi/templates/steps/singleton.ts.hbs
,/bocchi/templates/top-level/src/client.ts.hbs
Honestly it may be easier to just use the two example template files, generate test graph projects, and review the resulting code.