[Mellanox] update asic and module temperature in a thread #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platform/mellanox/mlnx-platform-api/sonic_platform/thermal_updater.py
Outdated
Show resolved
Hide resolved
platform/mellanox/mlnx-platform-api/sonic_platform/thermal_updater.py
Outdated
Show resolved
Hide resolved
platform/mellanox/mlnx-platform-api/sonic_platform/thermal_updater.py
Outdated
Show resolved
Hide resolved
|
|
||
| def wait_all_sfp_ready(self): | ||
| logger.log_notice('Waiting for all SFP modules ready...') | ||
| max_wait_time = 60 |
There was a problem hiding this comment.
test if 60 second is enough?
| def wait_all_sfp_ready(self): | ||
| logger.log_notice('Waiting for all SFP modules ready...') | ||
| max_wait_time = 60 | ||
| ready_set = set() |
There was a problem hiding this comment.
confirm with hw-mgmt if it is per cable control
platform/mellanox/mlnx-platform-api/sonic_platform/thermal_updater.py
Outdated
Show resolved
Hide resolved
| self.set_thermal_data(0, 'crit', self.get_asic_temp_critical_threashold()) | ||
| except Exception as e: | ||
| logger.log_error('Failed to update ASIC thermal data - {e}') | ||
| self.set_thermal_data(0, 'input', 'invalid') |
There was a problem hiding this comment.
TBD: confirm with hw-mgmt
| self._sfp_status[sfp.sdk_index] = presence | ||
| except Exception as e: | ||
| logger.log_error('Failed to update module {sfp.sdk_index} thermal data - {e}') | ||
| self.set_thermal_data(sfp.sdk_index + 1, 'input', 'invalid') |
There was a problem hiding this comment.
TBD: confirm with hw-mgmt
| temperature = super().get_temperature() | ||
| return temperature if temperature is not None else 0.0 | ||
|
|
||
| def get_temperature_warning_threashold(self): |
There was a problem hiding this comment.
TODO: retry reading threshold
keboliu
reviewed
Oct 19, 2023
keboliu
approved these changes
Oct 19, 2023
|
ci 3110 passed |
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Mar 18, 2024
…lly (sonic-net#18076) #### Why I did it src/sonic-gnmi ``` * d56712a - (HEAD -> master, origin/master, origin/HEAD) Update GNMI path schema (#197) (4 days ago) [ganglv] * 758ec18 - Call flag.Parse() to parse global flags like -logtostderr (#198) (5 days ago) [Zain Budhwani] * 736e3b4 - Add signal handler to stop gnmi server for when sigterm or sigquit is called (#189) (3 weeks ago) [Zain Budhwani] * 5b59c57 - Fix sonic string in osversion/build (#190) (4 weeks ago) [Zain Budhwani] * d8d15c7 - Enable unit tests and code coverage for telemetry.go (#186) (5 weeks ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)