[Mellanox] wait reset cause ready #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
force-pushed
the
master_fix_resetcause
branch
from
8a658ce
to
fd100b4
Compare
|
CI 2955 passed |
keboliu
reviewed
Sep 7, 2023
| @@ -806,6 +817,10 @@ def get_reboot_cause(self): | |||
| if reboot_cause: | |||
| return self.REBOOT_CAUSE_NON_HARDWARE, '' | |||
|
|
|||
| if not self._wait_reboot_cause_ready(): | |||
| logger.log_error("Hardware reboot cause is not ready") | |||
| return self.REBOOT_CAUSE_NON_HARDWARE, '' | |||
There was a problem hiding this comment.
shall we return 'unknown' here to indicate that something is wrong?
There was a problem hiding this comment.
we log error here
keboliu
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
SONiC service
determine-reboot-causemight run before driver creating reset cause files. In that case, the reset cause will be "Unknown". This PR introduces a wait mechanism to wait for reset cause sysfs files ready.Work item tracking
How I did it
/run/hw-management/config/reset_attr_ready is the file to indicate all reset cause files are ready. In
chassis.get_reboot_causefunction, it waits /run/hw-management/config/reset_attr_ready for up to 45 seconds.How to verify it
Manual test on master/202211/202205
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)