[Mellanox] Remove PSU set speed API

platform/mellanox/mlnx-platform-api/sonic_platform/fan.py

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2019-2022 NVIDIA CORPORATION & AFFILIATES.
+# Copyright (c) 2019-2023 NVIDIA CORPORATION & AFFILIATES.
 # Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -41,7 +41,6 @@
 PWM_MAX = 255
 
 FAN_PATH = "/var/run/hw-management/thermal/"
-CONFIG_PATH = "/var/run/hw-management/config"
 
 FAN_DIR = "/var/run/hw-management/thermal/fan{}_dir"
 FAN_DIR_VALUE_EXHAUST = 0
@@ -160,9 +159,6 @@ def __init__(self, fan_index, position, psu):
         self.fan_presence_path = os.path.join(FAN_PATH, "psu{}_fan1_speed_get".format(self.index))
         self.fan_max_speed_path = os.path.join(FAN_PATH, "psu{}_fan_max".format(self.index))
         self.fan_min_speed_path = os.path.join(FAN_PATH, "psu{}_fan_min".format(self.index))
-        self.psu_i2c_bus_path = os.path.join(CONFIG_PATH, 'psu{0}_i2c_bus'.format(self.index))
-        self.psu_i2c_addr_path = os.path.join(CONFIG_PATH, 'psu{0}_i2c_addr'.format(self.index))
-        self.psu_i2c_command_path = os.path.join(CONFIG_PATH, 'fan_command')
         self.psu_fan_dir_path = os.path.join(FAN_PATH, "psu{}_fan_dir".format(self.index))
 
     def get_direction(self):
@@ -221,34 +217,6 @@ def get_target_speed(self):
         except Exception:
             return self.get_speed()
 
-    def set_speed(self, speed):
-        """
-        Set fan speed to expected value
-
-        Args:
-            speed: An integer, the percentage of full fan speed to set fan to,
-                   in the range 0 (off) to 100 (full speed)
-
-        Returns:
-            bool: True if set success, False if fail.
-        """
-        if not self.get_presence():
-            return False
-
-        try:
-            bus = utils.read_str_from_file(self.psu_i2c_bus_path, raise_exception=True)
-            addr = utils.read_str_from_file(self.psu_i2c_addr_path, raise_exception=True)
-            command = utils.read_str_from_file(self.psu_i2c_command_path, raise_exception=True)
-            speed = self.PSU_FAN_SPEED[int(speed // 10)]
-            command = ["i2cset", "-f", "-y", bus, addr, command, speed, "wp"]
-            subprocess.check_call(command, universal_newlines=True)
-            return True
-        except subprocess.CalledProcessError as ce:
-            logger.log_error('Failed to call command {}, return code={}, command output={}'.format(ce.cmd, ce.returncode, ce.output))
-            return False
-        except Exception as e:
-            logger.log_error('Failed to set PSU FAN speed - {}'.format(e))
-            return False
 
 class Fan(MlnxFan):
     """Platform-specific Fan class"""

platform/mellanox/mlnx-platform-api/tests/test_fan_api.py

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2020-2022 NVIDIA CORPORATION & AFFILIATES.
+# Copyright (c) 2020-2023 NVIDIA CORPORATION & AFFILIATES.
 # Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -133,26 +133,3 @@ def test_psu_fan_basic(self, mock_path_exists, mock_powergood, mock_presence, mo
         assert fan.get_direction() == Fan.FAN_DIRECTION_EXHAUST
         mock_read_int.return_value = -1 # invalid value
         assert fan.get_direction() == Fan.FAN_DIRECTION_NOT_APPLICABLE
-
-    def test_psu_fan_set_speed(self):
-        psu = Psu(0)
-        fan = PsuFan(0, 1, psu)
-        subprocess.check_call = MagicMock()
-        mock_file_content = {
-            fan.psu_i2c_bus_path: 'bus',
-            fan.psu_i2c_addr_path: 'addr',
-            fan.psu_i2c_command_path: 'command'
-        }
-        def mock_read_str_from_file(file_path, default='', raise_exception=False):
-            return mock_file_content[file_path]
-        utils.read_str_from_file = mock_read_str_from_file
-        fan.set_speed(60)
-        assert subprocess.check_call.call_count == 0
-        fan.get_presence = MagicMock(return_value=True)
-        assert fan.set_speed(60)
-        subprocess.check_call.assert_called_with(["i2cset", "-f", "-y", "bus", "addr", "command", hex(60), "wp"], universal_newlines=True)
-        subprocess.check_call = MagicMock(side_effect=subprocess.CalledProcessError('', ''))
-        assert not fan.set_speed(60)
-        subprocess.check_call = MagicMock()
-        utils.read_str_from_file = MagicMock(side_effect=RuntimeError(''))
-        assert not fan.set_speed(60)