Skip to content

Commit

Permalink
Add yang model for PFC watchdog debug information (sonic-net#16206)
Browse files Browse the repository at this point in the history
### Why I did it
When PFC WD is triggered there is no diagnosis information which makes it difficult to understand why PFC WD was triggered. So, we add a field `additional_information` to accommodate the diagnosis information.

### How to verify it
unit test
  • Loading branch information
stephenxs authored Aug 23, 2023
1 parent c1c1054 commit 67863b8
Show file tree
Hide file tree
Showing 3 changed files with 54 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,17 @@
"SONIC_EVENTS_SWSS_PFC_STORM_VALID": {
"desc": "VALID IF_STATE EVENT."
},
"SONIC_EVENTS_SWSS_PFC_STORM_VALID_WITH_ADDITIONAL_INFO": {
"desc": "VALID IF_STATE EVENT."
},
"SONIC_EVENTS_SWSS_PFC_STORM_WITH_INVALID_ADDITIONAL_INFO_1": {
"desc": "PFC_STORM_EVENT_INCORRECT_ADDITIONAL_INFO failure.",
"eStrKey": "Pattern"
},
"SONIC_EVENTS_SWSS_PFC_STORM_WITH_INVALID_ADDITIONAL_INFO_2": {
"desc": "PFC_STORM_EVENT_INCORRECT_ADDITIONAL_INFO failure.",
"eStrKey": "Pattern"
},
"SONIC_EVENTS_SWSS_CHK_CRM_THRESHOLD_INCORRECT_PERCENT": {
"desc": "CHK_CRM_THRESHOLD_EVENT_INCORRECT_PERCENT failure.",
"eStrKey": "Range"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,42 @@
}
}
},
"SONIC_EVENTS_SWSS_PFC_STORM_VALID_WITH_ADDITIONAL_INFO": {
"sonic-events-swss:sonic-events-swss": {
"sonic-events-swss:pfc-storm": {
"ifname": "Ethernet0",
"queue_index": 0,
"queue_id": 0,
"port_id": 0,
"additional_info": "info1:1|info2:2",
"timestamp": "1985-04-12T23:20:50.52Z"
}
}
},
"SONIC_EVENTS_SWSS_PFC_STORM_WITH_INVALID_ADDITIONAL_INFO_1": {
"sonic-events-swss:sonic-events-swss": {
"sonic-events-swss:pfc-storm": {
"ifname": "Ethernet0",
"queue_index": 0,
"queue_id": 0,
"port_id": 0,
"additional_info": "info1:1|info2",
"timestamp": "1985-04-12T23:20:50.52Z"
}
}
},
"SONIC_EVENTS_SWSS_PFC_STORM_WITH_INVALID_ADDITIONAL_INFO_2": {
"sonic-events-swss:sonic-events-swss": {
"sonic-events-swss:pfc-storm": {
"ifname": "Ethernet0",
"queue_index": 0,
"queue_id": 0,
"port_id": 0,
"additional_info": "info1:1|",
"timestamp": "1985-04-12T23:20:50.52Z"
}
}
},
"SONIC_EVENTS_SWSS_CHK_CRM_THRESHOLD_INCORRECT_PERCENT": {
"sonic-events-swss:sonic-events-swss": {
"sonic-events-swss:chk_crm_threshold": {
Expand Down
7 changes: 7 additions & 0 deletions src/sonic-yang-models/yang-models/sonic-events-swss.yang
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,13 @@ module sonic-events-swss {
type uint64;
}

leaf additional_info {
type string {
pattern '[-a-zA-Z0-9_]+:[-a-zA-Z0-9_]+(\|{1}[-a-zA-Z0-9_]+:[-a-zA-Z0-9_]+)*';
}
description "Additional information to investigate PFC storm";
}

uses evtcmn:sonic-events-cmn;
}

Expand Down

0 comments on commit 67863b8

Please sign in to comment.