extend RecursiveArrayTools.issymbollike for Num
#997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,6 +26,7 @@ Markdown = "d6f4376e-aef5-505a-96c1-9c027394607a" | |||
| NaNMath = "77ba4419-2d1f-58cd-9bb1-8ffee604a2e3" | |||
| PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a" | |||
| RecipesBase = "3cdcf5f2-1ef4-517c-9805-6587b60abb01" | |||
| RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd" | |||
There was a problem hiding this comment.
it doesn't need one. This overload is valid for old versions.
There was a problem hiding this comment.
It still needs one in order to get registered 😅
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #997 +/- ##
==========================================
+ Coverage 77.87% 78.14% +0.27%
==========================================
Files 27 27
Lines 3371 3372 +1
==========================================
+ Hits 2625 2635 +10
+ Misses 746 737 -9
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
bump? |
ChrisRackauckas
merged commit 84c23db
into
JuliaSymbolics:master
12 of 17 checks passed
oscardssmith
added a commit
to oscardssmith/General
that referenced
this pull request
Oct 16, 2023
This is the last piece to get SciML/RecursiveArrayTools.jl#287 and JuliaSymbolics/Symbolics.jl#997 working.
ChrisRackauckas
pushed a commit
to JuliaRegistries/General
that referenced
this pull request
Oct 16, 2023
…#93498) This is the last piece to get SciML/RecursiveArrayTools.jl#287 and JuliaSymbolics/Symbolics.jl#997 working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This with SciML/RecursiveArrayTools.jl#287 fixes the generated function mess that used to be used to do this. This will require capping the RecursiveArrayTools version of older Symbolics releases, but I think that is the right approach here.