Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istree deprecation #1138

Merged

Conversation

ArnoStrouwen
Copy link
Contributor

The SciML packages which error on deprecations are complaining about the deprecation of istree in SymbolicUtils.
Is it already possible to propagate this change through the rest of the Symbolics/MTK stack?
I'm not sure if the change is as simple as replacing it with iscall

@ChrisRackauckas
Copy link
Member

Handle similarterm to maketerm as well?

@ArnoStrouwen
Copy link
Contributor Author

@ChrisRackauckas ChrisRackauckas merged commit a129272 into JuliaSymbolics:master May 17, 2024
7 of 11 checks passed
@ChrisRackauckas
Copy link
Member

oh did this need a lower bound @shashi @ArnoStrouwen ?

@ArnoStrouwen
Copy link
Contributor Author

The lower bound for Symbolicutils got updated before this was merged in, so I don't think so.

@ArnoStrouwen ArnoStrouwen deleted the istree_deprecation branch May 17, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants