-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADTypes sparsity detector #1134
Conversation
@ChrisRackauckas this is part of the great wave of updates |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1134 +/- ##
==========================================
- Coverage 77.07% 75.94% -1.13%
==========================================
Files 32 36 +4
Lines 3533 3692 +159
==========================================
+ Hits 2723 2804 +81
- Misses 810 888 +78 ☔ View full report in Codecov by Sentry. |
@Vaibhavdixit02 I think the NonLinearSolve upgrade needs to come first before this one. Let me know if you need help |
The only test failure that seems relevant is the downstream test with ModelingToolkit (https://github.com/JuliaSymbolics/Symbolics.jl/actions/runs/9127346950/job/25097459503?pr=1134). I think it is happening because OptimizationBase has not yet fully embraced ADTypes v1.0 (see SciML/OptimizationBase.jl#44). @Vaibhavdixit02 what do you think? |
Can you rebase onto the depwarn fixes? |
done |
Not sure that was a great idea though, nearly all tests fail on master now 🤔 |
@shashi is handling a big update over the next week, after which we will revisit this PR. |
No rush! |
Gentle bump on this one, it's absolutely non-destructive and would be useful for benchmarking |
Following the release of ADTypes.jl v1.0, this PR adds a
SymbolicsSparsityDetector
struct that implements the new sparsity pattern detection framework.SymbolicsSparsityDetector
structADTypes.jacobian_sparsity
andADTypes.hessian_sparsity
for general arrays, not just vectors