More test coverage for coeff #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a very trivial MR, but the goal is more to figure out y'alls workflow to hopefully contribute more meaningfully in the future. |
`coeff` works with symbolic and non-integral powers. However, this case is not covered in unit tests. Add tests to preserve this functionality into the future.
NAThompson
force-pushed
the
more_tests_for_coeff
branch
from
5b397b5
to
1568ebc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1133 +/- ##
==========================================
- Coverage 77.07% 75.85% -1.23%
==========================================
Files 32 35 +3
Lines 3533 3698 +165
==========================================
+ Hits 2723 2805 +82
- Misses 810 893 +83 ☔ View full report in Codecov by Sentry. |
bowenszhu
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coeffworks with symbolic and non-integral powers. However, this case is not covered in unit tests.Add tests to preserve this functionality into the future.