change binomial registration

JuliaSymbolics · Dec 29, 2023 · 5e3143c · 5e3143c
1 parent dc7c7a9
commit 5e3143c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/extra_functions.jl b/src/extra_functions.jl
@@ -1,4 +1,4 @@
-@register_symbolic Base.binomial(n, k::Integer)::Int true
+@register_symbolic Base.binomial(n, k)::Int true [Integer, Real]
 
 @register_symbolic Base.sign(x)::Int
 derivative(::typeof(sign), args::NTuple{1,Any}, ::Val{1}) = 0

diff --git a/test/overloads.jl b/test/overloads.jl
@@ -237,3 +237,18 @@ for f in [<, <=, >, >=, isless]
 end
 
 @test_nowarn binomial(t, 1)
+
+# test for https://github.com/JuliaSymbolics/Symbolics.jl/issues/1028
+let
+    @variables t A(t) B
+    @test try binomial(A, 2*B^2)
+        true
+    catch
+        false
+    end
+    @test try binomial(Symbolics.value(A), Symbolics.value(2*B^2))
+        true
+    catch
+        false
+    end
+end