-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data file generator with support for UCD 13 & 14 #228
Conversation
(UNICODE_VERSION): Added `14.0.0` default. [Note: It may be possible to remove the similar statement in data/Makefile but it may require updating all the calls to `$(MAKE) -C data …` in this file.] (test/misc): Use above UNICODE_VERSION var so that this target also builds with original utf8proc_data.c file. [Note: This test in test/misc is now redundant when using the new utf8proc_data.c files.] utf8proc.c - Restored changes from 610730f. (utf8proc_category): Fixed new warning.
@@ -26,6 +26,8 @@ MAJOR=2 | |||
MINOR=4 | |||
PATCH=1 | |||
|
|||
UNICODE_VERSION ?= 14.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading to Unicode 14 should happen in a separate PR.
|
||
|
||
def Print (s): | ||
print(s, file=sys.stderr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use PEP-8 style (https://www.python.org/dev/peps/pep-0008/), e.g. 4 space indenting … see e.g. https://github.com/hhatto/autopep8
usually python functions are not capitalized…
You mentioned that you didn't know Python before, and unfortunately this code is rather non-idiomatic.
return DDir+ "/" +name+ ".txt" | ||
|
||
def Sed (expr, file): | ||
return os.popen("/usr/bin/sed -En '" +expr+ "' '" +TextFile(file)+ "'", 'r', 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python has its own regex support; it's a little odd to call out to sed
etcetera
Is there any update on this? |
Closed in favor of #258. |
Closes #227.