Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure that the input String is GC preserved in equality check #81

Merged
merged 1 commit into from
Jul 23, 2024
Merged

ensure that the input String is GC preserved in equality check #81

merged 1 commit into from
Jul 23, 2024

Conversation

KristofferC
Copy link
Member

To me, it seems that nothing protects x from getting GCd after the pointer call right now.

@KristofferC KristofferC merged commit bf772fb into JuliaStrings:main Jul 23, 2024
6 checks passed
quinnj
quinnj reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; thanks.

@KristofferC KristofferC deleted the kc/preserve_x branch July 23, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KristofferC @quinnj