Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into fixing #15 but realized that the special casing of
InlineString1
to only have one byte makes that not work. I would say that the current special casing ofInlineString1
creates quite a bit of confusing behavior:Why would an empty string take more place than a one-letter string?
Wut?
Why would
rstrip
make it bigger?This looks like a bug?
There are also casts to
InlineString3
that have to be done for many of the operations onInlineString1
which probably makes them slower than storing the two bytes.There is nothing in the documentation that indicates this type of special behavior.
I'm sure there is some reason for doing this since so much pain seems to have been gone through to do it but I thought I would put up this PR nonetheless.
Fixes #73 Fixes #72