Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Parsers a weakdep #78

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

KristofferC
Copy link
Member

Rebase of #67.

[extensions]
ArrowTypesExt = "ArrowTypes"
ParsersExt = "Parsers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for my own edification, not really related to the PR: If two packages (say InlineStrings and SaxophoneHorse) have extensions for Parsers, both call their extension module ParsersExt, and you load InlineStrings, SaxophoneHorse, and Parsers, what happens? That is, does the convention of naming an extension module <main package><weakdep>Ext provide functional disambiguation or is it more for the benefit of the human?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, mostly answered my own question. Extension modules having the same name doesn't cause any issues, so I suppose the naming convention is more for the human's benefit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they have different UUID so the loading system can distinguish them.

Project.toml Outdated Show resolved Hide resolved
@ararslan ararslan merged commit 3458995 into JuliaStrings:main Jul 12, 2024
6 checks passed
@ararslan ararslan mentioned this pull request Jul 12, 2024
@KristofferC KristofferC deleted the aplavin/main branch July 12, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants