Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package extension to support InlineStrings in Arrow.jl #66

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Add package extension to support InlineStrings in Arrow.jl #66

merged 2 commits into from
Jun 20, 2023

Commits on Jun 14, 2023

  1. Add package extension to support InlineStrings in Arrow.jl 

    Fixes apache/arrow-julia#196.

This utilizes the new package extension feature of Julia 1.9 to
add a conditional dependency on the ArrowTypes.jl package. With
ArrowTypes.jl, it adds the necessary overloads to allow round-
tripping of inline strings through the arrow format. Other language
implementations will read them as normal strings, but in the Julia
implementation, the additional type metadata signal that these strings
were originally inline strings and can be deserialized as such.

I'm explicitly not using the Requires.jl hack for backwards compat w/
older Julia versions because I like the idea of this being sort of a
"beta" feature for users already using 1.9 to see if there are any
unexpected issues that pop up for inline strings in the arrow format.
    @quinnj
    quinnj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    d8094b8 View commit details
    Browse the repository at this point in the history

  2. Only test package extension on 1.9

    @quinnj
    quinnj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    0807e29 View commit details
    Browse the repository at this point in the history