-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add log rank testing #36
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
- Coverage 99.54% 98.67% -0.88%
==========================================
Files 6 6
Lines 222 377 +155
==========================================
+ Hits 221 372 +151
- Misses 1 5 +4
Continue to review full report at Codecov.
|
Great. |
Yes, for sure, adding the log-rank test to this package has been on my backlog of desired features since about 2017. 😄 Apologies, I should have spoken up on this PR sooner; I haven't been ignoring it. I have a number of internal changes planned that should be able to significantly simplify the implementation and I've finally gotten around to making some of them. Once that's in a good state I'll help adapt this PR accordingly. Thanks for the contribution and for your patience, @kshedden! |
Great, thanks for the update. Also, it would be very useful to have an |
Is log-rank testing expected to be available soon-ish? |
This PR adds log rank testing for comparing two or more fitted survival functions (fit with the Kaplan Meier estimator).
The unit tests are based on results from R and Stata.