Update Terms for Julia 0.6 changes #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
reviewed
Jan 5, 2017
| tt = tt[!(tt .== 1)] # drop any explicit 1's | ||
| noint = (tt .== 0) | (tt .== -1) # should also handle :(-(expr,1)) | ||
| filter!(t -> t != 1, tt) # drop any explicit 1's | ||
| noint = BitArray(map(t -> t == 0 || t == -1, tt)) # should also handle :(-(expr,1)) |
There was a problem hiding this comment.
Looks nifty but is apparently deprecated in 0.6
There was a problem hiding this comment.
Ah. So broadcast (but not map) will figure out that the return array should be BitArray.
There was a problem hiding this comment.
That will still fail the currently failing test because broadcast(t -> t == 1, tt) doesn't produce an empty BitArray if tt is empty; it produces Array{Any,1}.
There was a problem hiding this comment.
I think JuliaLang/julia#19854 fixed this. On latest master:
julia> broadcast(t -> t == 1, Float64[])
0-element BitArray{1}
Current coverage is 95.10% (diff: 100%)@@ master #11 diff @@
==========================================
Files 5 5
Lines 311 347 +36
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 291 330 +39
+ Misses 20 17 -3
Partials 0 0
|
|
Any objection to merging this as-is, @andreasnoack? |
|
I'll take that as a "no" 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple of things:
ttis inferred asArray{Any,1}, as istt .== 1, so!(tt .== 1)fails. Changed tofilter!.|is deprecated and.|doesn't exist in 0.5. Changed tomap.