Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weighted sem #754

Merged
merged 66 commits into from
Feb 6, 2022
Merged

Weighted sem #754

merged 66 commits into from
Feb 6, 2022

Conversation

ParadaCarleton
Copy link
Contributor

introduces methods for weighted standard error of the mean (sem)

src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
Co-authored-by: David Widmann <[email protected]>
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
Co-authored-by: David Widmann <[email protected]>
src/scalarstats.jl Outdated Show resolved Hide resolved
test/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
Co-authored-by: David Widmann <[email protected]>
src/moments.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
Co-authored-by: Milan Bouchet-Valat <[email protected]>
src/scalarstats.jl Outdated Show resolved Hide resolved
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ParadaCarleton! As you noticed, weighted statistics would benefit from more attention...

test/scalarstats.jl Outdated Show resolved Hide resolved
@ParadaCarleton
Copy link
Contributor Author

@devmotion Anything left, or should we merge?

src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
test/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ParadaCarleton ParadaCarleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devmotion ready to merge?

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
src/scalarstats.jl Outdated Show resolved Hide resolved
ParadaCarleton and others added 3 commits February 5, 2022 07:47
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
@ParadaCarleton
Copy link
Contributor Author

@devmotion removed the parentheses, so we can merge 👍

@nalimilan nalimilan merged commit afd0bb7 into JuliaStats:master Feb 6, 2022
@ParadaCarleton ParadaCarleton deleted the weighted-sem branch March 29, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants