Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow in mean(::AbstractRange) #122

Closed
wants to merge 1 commit into from

Conversation

jishnub
Copy link

@jishnub jishnub commented Jun 30, 2022

Fixes #120, now

julia> mean(Int8(123):Int8(123))
123.0

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #122 (9eb9a8e) into master (0588f2c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   96.94%   96.95%           
=======================================
  Files           1        1           
  Lines         426      427    +1     
=======================================
+ Hits          413      414    +1     
  Misses         13       13           
Impacted Files Coverage Δ
src/Statistics.jl 96.95% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0588f2c...9eb9a8e. Read the comment docs.

@jishnub
Copy link
Author

jishnub commented Jun 30, 2022

Seems to be a duplicate of #115

@jishnub jishnub closed this Jun 30, 2022
@jishnub jishnub deleted the meanoverflow branch June 30, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mean incorrectly computes means of ranges
2 participants