Add QP-rand problem #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 99.16% 99.18% +0.02%
==========================================
Files 10 11 +1
Lines 360 369 +9
==========================================
+ Hits 357 366 +9
Misses 3 3 ☔ View full report in Codecov by Sentry. |
dpo
requested changes
Mar 16, 2024
src/qp_rand_model.jl
Outdated
|
|
||
| ## Keyword arguments | ||
|
|
||
| * `dens :: Real`: density of `A`` used to generate the quadratic model (default: `1.0e-4`). |
src/qp_rand_model.jl
Outdated
| u = one(R) .+ rand(R, n) | ||
| qp = QuadraticModel(c, H; lvar = l, uvar = u) | ||
| x0 = zeros(R, n) | ||
| qp, x0 |
There was a problem hiding this comment.
x0 should be part of qp.meta. Also, the docstring does not say that you return x0.
test/runtests.jl
Outdated
| model, x0 = qp_rand_model(n; dens = dens, convex = false) | ||
| @test all(-2.0 .≤ model.meta.lvar .≤ 0.0) | ||
| @test all(0.0 .≤ model.meta.uvar .≤ 2.0) | ||
| @test all(model.meta.x0 .== x0) |
There was a problem hiding this comment.
Here it is. No need to return x0 above.
Co-authored-by: Dominique <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.