-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iterative refinement function #108
Add iterative refinement function #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add entries for qrm_refine!
and qrm_refine
in the documentation?
For the docstring of qrm_refine!
, I suggest to also specify the length of each vector.
You say at the top of the docstring that (m, n)
is the size of A
and explain that each vector is of size n
or m
.
Good job!
@MaxenceGollier thank you. Because |
I prefer to avoid specifying the dimension of
I agree, I will add a separate PR for that. |
Could you add an option to refine It will require more work to address the request of Dominique: |
I don't see in what situation a problem like |
You're right, except if |
19cc2f8
into
JuliaSmoothOptimizers:main
I added a Julia function that given an approximate solution$$x$$ refines a solution of the system $$R^TR x \approx z$$ .
Let me know what you think @dpo @amontoison when you have some time.