Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiagonalBFGSModel #127

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MohamedLaghdafHABIBOULLAH

Add DiagonalBFGSModel where the hessian is approximated by DiagonalBFGS from LinearOperators.jl

@dpo
Copy link
Member

dpo commented Sep 12, 2024

We need a push!() method to update the operator.

@MohamedLaghdafHABIBOULLAH
Copy link
Author

MohamedLaghdafHABIBOULLAH commented Sep 12, 2024

@MohamedLaghdafHABIBOULLAH
Copy link
Author

@dpo pourrais tu me donner ton avis sur cette PR ?

@dpo
Copy link
Member

dpo commented Oct 15, 2024

I don’t think we want to maintain a nondiagonal LBFGS operator just to construct this one.

@MohamedLaghdafHABIBOULLAH
Copy link
Author

I don't quite get it. I did the same for other diagonal quasi-Newton updates, such as DiagonalPSBModel, DiagonalAndreiModel, and SpectralGradientModel, for which we have already defined quasi-Newton linear operators within LinearOperators.jl.

Should I do the same for all other diagonal updates and use only the quasi-Newton linear operators ?

@dpo
Copy link
Member

dpo commented Oct 28, 2024

There is no DiagonalBFGS operator in LinearOperators: https://github.com/search?q=repo%3AJuliaSmoothOptimizers%2FLinearOperators.jl%20DiagonalBFGS&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants