Skip to content

Commit

Permalink
Fix warnings (#264)
Browse files Browse the repository at this point in the history
* remove conflict with Krylov

* remove warning in FOMO
  • Loading branch information
tmigot authored Mar 22, 2024
1 parent 8d2e8d2 commit b9aeef0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion src/JSOSolvers.jl
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ using LinearAlgebra, Logging, Printf
using Krylov, LinearOperators, NLPModels, NLPModelsModifiers, SolverCore, SolverTools

import SolverCore.solve!
import Krylov.solve!
export solve!

# Unconstrained solvers
Expand Down
2 changes: 1 addition & 1 deletion src/fomo.jl
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ Compute value `βmax` that saturates the contribution of the momentum term to th
2. ‖∇f(xk)‖ ≥ θ2 * ‖(1-βmax) * ∇f(xk) .+ βmax .* m‖
with `m` the momentum term and `mdot∇f = ∇f(xk)ᵀm`
"""
function find_beta(diff_norm::T, mdot∇f::T, norm_∇f::T, β::T, θ1::T, θ2::T) where {T, V}
function find_beta(diff_norm::T, mdot∇f::T, norm_∇f::T, β::T, θ1::T, θ2::T) where {T}
n1 = norm_∇f^2 - mdot∇f
β1 = n1 > 0 ? (1 - θ1) * norm_∇f^2 / n1 : β
β2 = diff_norm != 0 ? (1 - θ2) * norm_∇f / diff_norm : β
Expand Down

0 comments on commit b9aeef0

Please sign in to comment.