Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow plotting profiles from integer data #116

Merged
merged 1 commit into from
May 24, 2024
Merged

allow plotting profiles from integer data #116

merged 1 commit into from
May 24, 2024

Conversation

dpo
Copy link
Member

@dpo dpo commented May 24, 2024

Previously, only Float64 data was accepted. Integer data is relevant when plotting profiles based on, e.g., the number of objective evaluations.

@dpo dpo requested a review from tmigot May 24, 2024 22:46
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.41%. Comparing base (e4fb672) to head (89e69a2).
Report is 1 commits behind head on main.

Current head 89e69a2 differs from pull request most recent head ff033d0

Please upload reports for the commit ff033d0 to get more accurate results.

Files Patch % Lines
src/performance_profiles.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   96.09%   96.41%   +0.32%     
==========================================
  Files           5        5              
  Lines         307      307              
==========================================
+ Hits          295      296       +1     
+ Misses         12       11       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dpo looks good to me.
Could you also update the docstring if needed:

Copy link
Contributor

Package name latest stable
SolverBenchmark.jl

Previously, only Float64 data was accepted. Integer data is relevant
when plotting profiles based on, e.g., the number of objective
evaluations.
@dpo
Copy link
Member Author

dpo commented May 24, 2024

Done!

Copy link
Contributor

Package name latest stable
SolverBenchmark.jl

@dpo dpo merged commit f320f23 into main May 24, 2024
17 checks passed
@dpo dpo deleted the int-profiles branch May 24, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants