Skip to content

Don't use Reexport as a dependency anymore. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion REQUIRE
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ OrdinaryDiffEq
DiffEqCallbacks 0.4.0
RigidBodyTreeInspector 0.3.2
LoopThrottle 0.0.1
Reexport
33 changes: 9 additions & 24 deletions notebooks/Quick start guide.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -134,17 +134,11 @@
}
],
"source": [
"using RigidBodySim"
]
},
{
"cell_type": "markdown",
"metadata": {},
"source": [
"Note that, for convenience, `RigidBodySim` reexports symbols from the following packages:\n",
"* [RigidBodyDynamics.jl](https://github.com/tkoolen/RigidBodyDynamics.jl)\n",
"* [OrdinaryDiffEq.jl](https://github.com/JuliaDiffEq/OrdinaryDiffEq.jl), part of the [DifferentialEquations.jl](https://github.com/JuliaDiffEq/DifferentialEquations.jl) ecosystem.\n",
"* [RigidBodyTreeInspector.jl](https://github.com/rdeits/RigidBodyTreeInspector.jl)"
"using RigidBodySim\n",
"using RigidBodyDynamics\n",
"using OrdinaryDiffEq\n",
"using DiffEqCallbacks\n",
"using RigidBodyTreeInspector"
]
},
{
Expand Down Expand Up @@ -262,16 +256,7 @@
"metadata": {
"collapsed": false
},
"outputs": [
{
"name": "stderr",
"output_type": "stream",
"text": [
"Bus::open: Can not get ibus-daemon's address. \n",
"IBusInputContext::createInputContext: no connection to ibus-daemon \n"
]
}
],
"outputs": [],
"source": [
"any_open_visualizer_windows() || (new_visualizer_window(); sleep(1));"
]
Expand Down Expand Up @@ -530,7 +515,7 @@
"text/plain": [
"DiffEqBase.ODEProblem with uType Array{Float64,1} and tType Float64. In-place: true\n",
"timespan: (0.0, 5.0)\n",
"u0: [0.0438264, 0.481333, -1.53895, -0.239899]"
"u0: [0.195491, 0.440061, 1.05505, 0.918594]"
]
},
"execution_count": 14,
Expand Down Expand Up @@ -609,15 +594,15 @@
],
"metadata": {
"kernelspec": {
"display_name": "Julia 0.6.0",
"display_name": "Julia 0.6.1",
"language": "julia",
"name": "julia-0.6"
},
"language_info": {
"file_extension": ".jl",
"mimetype": "application/julia",
"name": "julia",
"version": "0.6.0"
"version": "0.6.2"
}
},
"nbformat": 4,
Expand Down
10 changes: 4 additions & 6 deletions src/RigidBodySim.jl
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,10 @@ export
any_open_visualizer_windows,
new_visualizer_window

using Reexport

@reexport using RigidBodyDynamics
@reexport using OrdinaryDiffEq
@reexport using DiffEqCallbacks
@reexport using RigidBodyTreeInspector
using RigidBodyDynamics
using OrdinaryDiffEq
using DiffEqCallbacks
using RigidBodyTreeInspector

using LoopThrottle
using JSON
Expand Down
9 changes: 8 additions & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
module RigidBodySimTest

using RigidBodySim
using RigidBodyDynamics
using DrakeVisualizer
using RigidBodyTreeInspector
using OrdinaryDiffEq
using DiffEqCallbacks

using DrakeVisualizer
using JSON
using LCMCore

using Base.Test

function send_control_message(lcm::LCM, contents::Associative)
Expand Down Expand Up @@ -189,3 +194,5 @@ end
end
end
end

end