Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: head is incorrect for get_pull_requests #432

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: head is incorrect for get_pull_requests #432

merged 1 commit into from
Feb 7, 2024

Conversation

nkottary
Copy link
Member

@nkottary nkottary commented Feb 7, 2024 •
edited
Loading

Broken by #431. get_pull_requests requires head to be mentioned in the format $owner:$branch always.

With just branch it retrieves all pull requests, Example:

Error: Expected to find one open pull request created from a previous registration attempt but got 30 pull requests

@nkottary
fix: head is incorrect for get_pull_requests
f435944 
Broken by JuliaRegistries#431. get_pull_requests requires head to be mentioned in the format $owner:$branch always
@nkottary nkottary requested a review from zot February 7, 2024 09:40
zot
zot approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@zot zot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nkottary nkottary merged commit cd0c27d into JuliaRegistries:master Feb 7, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zot zot zot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkottary @zot