Remove exception=get_backtrace(...) pattern (#428)

src/commentbot/CommentBot.jl

@@ -210,8 +210,8 @@ function action(rp::RequestParams{T}, zsock::RequestSocket) where T <: RegisterT
             set_error_status(rp)
         end
     catch ex
-        bt = get_backtrace(ex)
-        @info("Unexpected error: $bt")
+        @info "Unexpected error" exception = (ex, catch_backtrace())
+        bt = sprint(Base.showerror, ex, catch_backtrace())
         raise_issue(rp.evt, rp.phrase, bt)
     end
     @info("Done processing register event", reponame=rp.reponame, target_registry_name)

src/commentbot/approval.jl

@@ -25,7 +25,7 @@ function get_metadata_from_pr_body(rp::RequestParams, auth)
         meta = String(decrypt(MbedTLS.CIPHER_AES_128_CBC, key, hex2bytes(enc_meta), key))
         return JSON.parse(meta)
     catch ex
-        @debug("Exception occured while parsing PR body", get_backtrace(ex))
+        @debug "Exception occured while parsing PR body" exception = (ex, catch_backtrace())
     end
 
     nothing
@@ -140,8 +140,8 @@ function action(rp::RequestParams{ApprovalTrigger}, zsock)
             make_comment(rp.evt, "Error in approval process: $err")
         end
     catch ex
-        bt = get_backtrace(ex)
-        @info("Unexpected error: $bt")
+        @info "Unexpected error" exception = (ex, catch_backtrace())
+        bt = sprint(Base.showerror, ex, catch_backtrace())
         raise_issue(rp.evt, rp.phrase, bt)
     end
     @info("Done processing approval event", reponame=rp.reponame, rp.trigger_src.prid)

src/management.jl

@@ -1,5 +1,3 @@
-get_backtrace(ex) = sprint(Base.showerror, ex, catch_backtrace())
-
 function get_log_level(l)
     log_level_str = lowercase(l)
 
@@ -64,7 +62,7 @@ function recover(
                 @warn("Stopping", name)
                 return
             else # exception_action == :continue
-                @error("Recovering from unknown exception", name, backoff, exception=get_backtrace(ex))
+                @error "Recovering from unknown exception" name backoff exception = (ex, catch_backtrace())
                 sleep(backoff)
                 backoff = min(backoffmax, backoff+backoffincrement)
             end

src/webui/gitutils.jl

@@ -248,7 +248,7 @@ function gettreesha(
             readchomp(`git -C $dest rev-parse $ref:$subdir`), ""
         end
     catch ex
-        @error("Exception while getting tree SHA", exception=get_backtrace(ex))
+        @error "Exception while getting tree SHA" exception=(ex, catch_backtrace())
         nothing, "Exception while getting tree SHA"
     end
 end

src/webui/routes/register.jl

@@ -42,7 +42,7 @@ function register(r::HTTP.Request)
     project = try
         RegistryTools.Project(TOML.parse(IOBuffer(toml)))
     catch e
-        @error "Reading project from (Julia)Project.toml failed" exception=get_backtrace(e)
+        @error "Reading project from (Julia)Project.toml failed" exception=(e, catch_backtrace())
         return json(400; error="(Julia)Project.toml is invalid")
     end
     for k in [:name, :uuid, :version]