Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the extras block when checking for new versions #502

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andreasnoack
Copy link
Contributor

With the work in #458, it seems like it's pretty simple to close #166 as also conjectured in that issue.

@DilumAluthge
Copy link
Member

Should we make this toggleable? And should it be opt-in or opt-out?

@DilumAluthge
Copy link
Member

Some thoughts:

  1. The main use case for [extras] is test-only deps. Most packages in the ecosystem currently don't have [compat] entries for their test-only deps, so this would lead to a surge of new PRs across the ecosystem.
  2. AutoMerge requires packages to have [compat] entries for all regular deps. However, AutoMerge, doesn't currently require packages to have [compat] entries for test-only deps1. CompatHelper was originally invented for the purpose of helping users meet the AutoMerge requirements. In some sense, that continues to be a core purpose of CompatHelper, so perhaps it makes sense that for the default behavior to be congruent with what AutoMerge requires (with of course the ability for users to opt-in to additional functionalities).

Footnotes

  1. Maybe we should add that requirement, but that's likely a discussion for a different day.

@andreasnoack
Copy link
Contributor Author

There is indeed a significant difference between direct package dependencies and test dependencies in that the latter can't break the environment alone, so having wrong compat (e.g. no) bounds on test dependencies could be considered a private matter. However, I don't really see why it was ever a good idea not to have compat bounds on test dependencies. It's not at all obvious that new versions of test dependencies wouldn't break your tests. However, bottomline here is probably that it should be opt-in. This will require a little more work on the PR, though.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7ea4330) to head (1aea258).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #502   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          412       410    -2     
=========================================
- Hits           412       410    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check "extras" not just "deps" ?
2 participants