Avoid deprecated BLAS.vendor() in MKL conflict check #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch as suggested by Carsten Bauer in JuliaPy#922. GitHub: Fixes JuliaPy#922.
giordano
reviewed
Jan 1, 2022
Co-authored-by: Mosè Giordano <[email protected]>
tkf
approved these changes
Jan 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #950 +/- ##
==========================================
- Coverage 68.33% 68.33% -0.01%
==========================================
Files 20 20
Lines 2018 2021 +3
==========================================
+ Hits 1379 1381 +2
- Misses 639 640 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Can this be merged? |
|
bump |
tkf
reviewed
Mar 3, 2022
|
Registering: JuliaRegistries/General#55870 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch as suggested by Carsten Bauer in #922.
As discussed in #922, the new BLAS trampoline magic might allow us to avoid this issue altogether, but this is nontrivial, as it would involve loading MKL in two different configurations even if it did work (the libtrampoline author wasn't sure about that either). For now, this avoids the annoying warning every time PyCall is loaded.