Skip to content

Commit

Permalink
Fix deprecations (#91)
Browse files Browse the repository at this point in the history
  • Loading branch information
femtocleaner[bot] authored and omus committed Dec 7, 2017
1 parent eca5315 commit 6ca6a3b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
11 changes: 1 addition & 10 deletions src/Conda.jl
Original file line number Diff line number Diff line change
Expand Up @@ -186,16 +186,7 @@ function _install_conda(env::Environment, force::Bool=false)
run(`$installer -b -f -p $PREFIX`)
end
if Compat.Sys.iswindows()
if VERSION >= v"0.5.0-dev+8873" # Julia PR #13780
run(Cmd(`$installer /S /AddToPath=0 /RegisterPython=0 /D=$PREFIX`, windows_verbatim=true))
else
# Workaround a bug in command-line argument parsing, see
# https://github.com/Luthaf/Conda.jl/issues/17
if match(r" {2,}", "") != nothing
error("The installer will fail when the path=\"$PREFIX\" contains two consecutive spaces")
end
run(`$installer /S /AddToPath=0 /RegisterPython=0 $(split("/D=$PREFIX"))`)
end
run(Cmd(`$installer /S /AddToPath=0 /RegisterPython=0 /D=$PREFIX`, windows_verbatim=true))
end
Conda.add_channel("defaults")
# Update conda because conda 4.0 is needed and miniconda download installs only 3.9
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ end

@test isfile(Conda.conda_bin(env))
Conda.add("python", env)
pythonpath = joinpath(Conda.python_dir(env), "python" * (Compat.Sys.iswindows() ? ".exe": ""))
pythonpath = joinpath(Conda.python_dir(env), "python" * (Compat.Sys.iswindows() ? ".exe" : ""))
@test isfile(pythonpath)
pyversion = readstring(`$pythonpath -c "import sys; print(sys.version)"`)
@test pyversion[1:1] == Conda.MINICONDA_VERSION
Expand Down

0 comments on commit 6ca6a3b

Please sign in to comment.