Skip to content
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.

Allow one arg version of violin and boxplot #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

piever
Copy link
Member

@piever piever commented Mar 13, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #66 into master will increase coverage by 0.14%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   66.59%   66.73%   +0.14%     
==========================================
  Files          16       16              
  Lines         452      460       +8     
==========================================
+ Hits          301      307       +6     
- Misses        151      153       +2
Impacted Files Coverage Δ
src/recipes/boxplot.jl 89.47% <100%> (+0.18%) ⬆️
src/recipes/violin.jl 93.75% <75%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f376b4...d839ceb. Read the comment docs.

@sethaxen
Copy link
Member

#107 also contains an implementation of a single arg version. Should we keep that or go with this one?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants