Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the metadata tags in the flamegraph UI by default #91

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Oct 20, 2023

Add an option to show the metadata tags in the flamegraph view, as root nodes, like this:
Screenshot 2023-10-20 at 4 57 49 PM

I don't love that the tags aren't labelled..... I've asked about that here:
google/pprof#811

I'm also not sure if tagroot= is the right way to expose this. Maybe it should be higher-level, like metadata::Bool and we just add this? Or groupby=["taskid", "threadid"], and we turn that into tagroots?

@NHDaly NHDaly requested a review from vchuravy October 20, 2023 22:59
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #91 (c2ec74d) into vc/tags (2a789ae) will decrease coverage by 0.60%.
Report is 1 commits behind head on vc/tags.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           vc/tags      #91      +/-   ##
===========================================
- Coverage    96.60%   96.01%   -0.60%     
===========================================
  Files            3        3              
  Lines          324      326       +2     
===========================================
  Hits           313      313              
- Misses          11       13       +2     
Files Coverage Δ
src/PProf.jl 98.00% <75.00%> (-0.65%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from vc/tags to main November 16, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants