Skip threads tests which are known to fail #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
changed the title
simonbyrne
approved these changes
Nov 3, 2023
|
great, now we get a weird macos failure |
giordano
force-pushed
the
mg/skip-intel-threads
branch
from
60ce7e4
to
43b325f
Compare
5 tasks
|
Fully green CI run on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it's useful to have a constant red mark because of a known issue which is already tracked by a specific ticket (#725). An attempt to resolve the issue with a suggested fix (#742) didn't work, so we aren't going to have this green in the near future.
PR best reviewed by skipping whitespace changes.