-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FMUComplianceChecker] Add builder #4284
[FMUComplianceChecker] Add builder #4284
Conversation
|
||
# Collection of sources required to complete build | ||
sources = [ | ||
ArchiveSource("https://github.com/modelica-tools/FMUComplianceChecker/releases/download/2.0.4/FMUChecker-2.0.4-linux64.zip", "02f6d1a175fe4c51d5840ef40fcd05ca7fb3ceec170d7825d9c946d75eae12eb"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ArchiveSource("https://github.com/modelica-tools/FMUComplianceChecker/releases/download/2.0.4/FMUChecker-2.0.4-linux64.zip", "02f6d1a175fe4c51d5840ef40fcd05ca7fb3ceec170d7825d9c946d75eae12eb"), | |
ArchiveSource("https://github.com/modelica-tools/FMUComplianceChecker/releases/download/$(version)/FMUChecker-$(version)-linux64.zip", "02f6d1a175fe4c51d5840ef40fcd05ca7fb3ceec170d7825d9c946d75eae12eb"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this binary would work on a Musl-based system
@sharanry Hey! Maybe I'm missing something here, but have you thought about building this project from source, so that you can generate binaries for all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although we occasionally redistribute pre-built binaries, I agree that it may be better (and actually easier) to build from source.
|
||
# Collection of sources required to complete build | ||
sources = [ | ||
ArchiveSource("https://github.com/modelica-tools/FMUComplianceChecker/releases/download/2.0.4/FMUChecker-2.0.4-linux64.zip", "02f6d1a175fe4c51d5840ef40fcd05ca7fb3ceec170d7825d9c946d75eae12eb"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this binary would work on a Musl-based system
@jeremiahpslewis I tried doing that. But the I am facing a subversion certificate error while checking out when trying to build from source. Maybe I will give it a go in the CI once? |
@sharanry You might look at one of the existing cmake build scripts (maybe this one https://github.com/JuliaPackaging/Yggdrasil/blob/master/C/Chuffed/build_tarballs.jl) and take things from there? (And afaik, no harm in sending things through CI and checking what you get) :) |
@giordano @jeremiahpslewis This is the error I am facing with subversion. Have you come across this before? |
It's an upstream bug: modelica-tools/FMUComplianceChecker#62 |
@giordano Could we redistribute pre-built binaries until that is resolved upstream? |
@sharanry What about working with a patch for this section of the CMake file which uses an env var or hardcodes the version? https://github.com/modelica-tools/FMUComplianceChecker/blob/master/CMakeLists.txt#L171:L186 |
@giordano Linux builds successfully. However, I am facing issues with Windows.
I didn't see them in the generators list. Any way those mentioned above can be supported? |
Ignore those instructions. And their CMake script is crap. You have to do something similar to |
It's a castle of crap CMake files, also https://github.com/modelon-community/fmi-library doesn't forward the toolchain file |
66c94ff
to
5205692
Compare
5205692
to
ddd2b82
Compare
15de59d
to
68f1a37
Compare
68f1a37
to
3394a92
Compare
For the time being 14 platforms out of 16 working. |
All green now. It wasn't that hard after all, right? 😉 |
Co-authored-by: Mosè Giordano <[email protected]>
Thanks a lot, @giordano! That was just amazing to watch 😅. |
* [New Package] FMUComplianceChecker * Update build_tarballs.jl * Update build_tarballs.jl * Update build_tarballs.jl * Update build_tarballs.jl * Update build_tarballs.jl * Update build_tarballs.jl * Update build_tarballs.jl * Update build_tarballs.jl * Update build_tarballs.jl * Update build_tarballs.jl * fix typo * Updates based on review * Update checksum * Move binaries manually * [FMUComplianceChecker] Add patches and build for all platforms * [FMUComplianceChecker] Use proper libtool for macOS * [FMUComplianceChecker] Remove extra stuff from the tarball * Update F/FMUComplianceChecker/build_tarballs.jl Co-authored-by: Mosè Giordano <[email protected]> Co-authored-by: Mosè Giordano <[email protected]>
No description provided.