Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIRV-Tools: Bump to 2024.4-rc2 #10529

Merged
merged 2 commits into from
Feb 14, 2025
Merged

SPIRV-Tools: Bump to 2024.4-rc2 #10529

merged 2 commits into from
Feb 14, 2025

Conversation

maleadt
Copy link
Contributor

@maleadt maleadt commented Feb 14, 2025

Bumping to a release candidate is kinda sketchy, but 2024.3 has bugs that need solving. So it's either moving forwards to a relatively stable release candidate, or backporting a whole bunch of code.

@maleadt
Copy link
Contributor Author

maleadt commented Feb 14, 2025

Apparently spirv-objdump is depended on by other targets, so I can't simply disable it. I had done this before because of C++-related compilation issues, which are resolved for Linux once upgrading GCC, but in macOS I'm still encountering a build error related to C++17's filesystem support:

[11:27:24] ld64.lld: error: undefined symbol: std::__1::__fs::filesystem::__status(std::__1::__fs::filesystem::path const&, std::__1::error_code*)
[11:27:24] >>> referenced by tools/CMakeFiles/spirv-objdump.dir/objdump/objdump.cpp.o:(symbol (anonymous namespace)::OutputSourceFiles(std::__1::unordered_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::hash<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, bool)+0x39b)
[11:27:24] >>> referenced by tools/CMakeFiles/spirv-objdump.dir/objdump/objdump.cpp.o:(symbol (anonymous namespace)::OutputSourceFiles(std::__1::unordered_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::hash<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, bool)+0x104)
[11:27:24]
[11:27:24] ld64.lld: error: undefined symbol: std::__1::__fs::filesystem::path::__filename() const
[11:27:24] >>> referenced by tools/CMakeFiles/spirv-objdump.dir/objdump/objdump.cpp.o:(symbol (anonymous namespace)::OutputSourceFiles(std::__1::unordered_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::hash<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, bool)+0x1bc)
[11:27:24] >>> referenced by tools/CMakeFiles/spirv-objdump.dir/objdump/objdump.cpp.o:(symbol std::__1::__fs::filesystem::operator/(std::__1::__fs::filesystem::path const&, std::__1::__fs::filesystem::path const&)+0x2d)
[11:27:24]
[11:27:24] ld64.lld: error: undefined symbol: std::__1::__fs::filesystem::__create_directories(std::__1::__fs::filesystem::path const&, std::__1::error_code*)
[11:27:24] >>> referenced by tools/CMakeFiles/spirv-objdump.dir/objdump/objdump.cpp.o:(symbol (anonymous namespace)::OutputSourceFiles(std::__1::unordered_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::hash<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, bool)+0x118)
[11:27:24]
[11:27:24] ld64.lld: error: undefined symbol: std::__1::__fs::filesystem::path::__root_directory() const
[11:27:24] >>> referenced by tools/CMakeFiles/spirv-objdump.dir/objdump/objdump.cpp.o:(symbol std::__1::__fs::filesystem::operator/(std::__1::__fs::filesystem::path const&, std::__1::__fs::filesystem::path const&)+0x16)
[11:27:24] clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Does that sound familiar to anybody?

@giordano
Copy link
Member

# `std::filesystem` support was introduced in macOS 10.15

@maleadt maleadt merged commit d64bb19 into master Feb 14, 2025
30 checks passed
@maleadt maleadt deleted the tb/spirv_tools branch February 14, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants