Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDiag: new version 0.3.1 #10511

Merged
merged 11 commits into from
Feb 13, 2025
Merged

XDiag: new version 0.3.1 #10511

merged 11 commits into from
Feb 13, 2025

Conversation

awietek
Copy link
Contributor

@awietek awietek commented Feb 11, 2025

No description provided.

@giordano
Copy link
Member

For Windows

The math constants aren't defined in Standard C/C++. To use them, you must first define _USE_MATH_DEFINES, and then include <cmath> or <math.h>.

@awietek
Copy link
Contributor Author

awietek commented Feb 11, 2025

Thanks, I figured this out and now some windows compilation is working. I have another question for OSX on the arm chips. I am currently compiling with GNU OpenMP, but you mentions LLVM OpenMP is preferable. At the time, LLVM OpenMP did not work, there were some segfaults if I remember. With GNU OpenMP it compiles and works, it's just not parallel. I realized there was this discussion, I was mentioned:

#9423

which seemed to have fixed this issue. Is it clear now what to do to use OpenMP on apple arm? Should I maybe try adapting this solution for the build script?

@giordano giordano merged commit 2064599 into JuliaPackaging:master Feb 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants