[Reactant_jll] - Fix the reading of "cuda_version_tag" in ENV for platform augmentation. #10506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take over this later, but please wait for https://buildkite.com/julialang/yggdrasil/builds/17546 to finish and the following PR to the merged. Also, this change doesn't require a full rebuild of Reactant (which takes 3 hours) but ony to regenerate the wrapper: https://github.com/JuliaPackaging/Yggdrasil/blob/master/CONTRIBUTING.md#special-keywords-in-commit-messages |
alexiscltrn
changed the title
I believe this might be a typo. I need to temporarily set ENV['REACTANT_GPU'] and ENV['REACTANT_CUDA_VERSION'] in order to fetch the correct tarball of Reactant_jll before sending it to my cluster (the platform is different from my local one). [skip build]
giordano
changed the title
|
Thanks! |
|
Thank you very much for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@avik-pal, @wsmoses
I believe this might be a typo. I need to temporarily set
ENV['REACTANT_GPU']andENV['REACTANT_CUDA_VERSION']in order to fetch the correct tarball ofReactant_jllbefore sending it to my cluster (the platform is different from my local one).