[ITK-v5.3.1] Fixing Windows minc error #10500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Feb 11, 2025
I/ITK/build_tarballs.jl
Outdated
Comment on lines
14
to
37
| cd $WORKSPACE/srcdir/ITK* | ||
| mkdir build/ | ||
| cmake -B build -S . \ | ||
| -DCMAKE_INSTALL_PREFIX=${prefix} \ | ||
| -DCMAKE_BUILD_TYPE=Release \ | ||
| -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TARGET_TOOLCHAIN} \ | ||
| -DBUILD_SHARED_LIBS:BOOL=ON \ | ||
| -DITK_USE_SYSTEM_EXPAT:BOOL=ON \ | ||
| -DITK_USE_SYSTEM_FFTW:BOOL=ON \ | ||
| -DITK_USE_SYSTEM_HDF5:BOOL=ON \ | ||
| -DITK_USE_SYSTEM_JPEG:BOOL=ON \ | ||
| -DITK_USE_SYSTEM_TIFF:BOOL=ON \ | ||
| -DITK_USE_SYSTEM_PNG:BOOL=ON \ | ||
| -DITK_USE_SYSTEM_EIGEN:BOOL=ON \ | ||
| -DITK_USE_SYSTEM_ZLIB:BOOL=ON \ | ||
| -DQNANHIBIT_VALUE:BOOL=0 \ | ||
| -DQNANHIBIT_VALUE__TRYRUN_OUTPUT:STRING=0 \ | ||
| -DVXL_HAS_SSE2_HARDWARE_SUPPORT:STRING=1 \ | ||
| -DVCL_HAS_LFS:STRING=1 \ | ||
| -DDOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS:STRING=1 \ | ||
| -DHAVE_CLOCK_GETTIME_RUN:STRING=0 | ||
| cmake --build build --parallel ${nproc} | ||
| cmake --install build | ||
| install_license ${WORKSPACE}/srcdir/ITK/LICENSE |
There was a problem hiding this comment.
Avoid duplication, you're running pretty much the same commands in the other branch too.
Co-authored-by: Mosè Giordano <[email protected]>
|
Hello, I tried simplifying the script but it appears I have some flags that need to run additionally on non-windows platforms, and the simplification resulted in other platforms breaking, is it possible i can have 2 different |
Sure, but add those flags conditionally only on Windows. |
|
done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.