Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactant_jll v0.0.65 #10494

Merged
merged 7 commits into from
Feb 11, 2025
Merged

Reactant_jll v0.0.65 #10494

merged 7 commits into from
Feb 11, 2025

Conversation

avik-pal
Copy link
Contributor

No description provided.

@giordano
Copy link
Member

[06:08:43] API.cpp:773:50: error: incompatible pointer types assigning to 'long *' from 'int64_t *' (aka 'long long *')
[06:08:43]   773 |     jl_op_sharding->tile_assignment_dimensions = new int64_t[
[06:08:43]       |                                                  ^~~~~~~~~~~~
[06:08:43]   774 |         tile_assignment_dimensions.size()];
[06:08:43]       |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[06:08:43] API.cpp:782:47: error: incompatible pointer types assigning to 'long *' from 'int64_t *' (aka 'long long *')
[06:08:43]   782 |     jl_op_sharding->tile_assignment_devices = new int64_t[tile_assignment_devices.size()];
[06:08:43]       |                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[06:08:43] API.cpp:789:41: error: incompatible pointer types assigning to 'long *' from 'int64_t *' (aka 'long long *')
[06:08:43]   789 |     jl_op_sharding->iota_reshape_dims = new int64_t[iota_reshape_dims.size()];
[06:08:43]       |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[06:08:43] 3 errors generated.

@avik-pal
Copy link
Contributor Author

This should now have the OpSharding + @mofeing's IFRT changes + some of the new passes in EnzymeJAX

@giordano giordano enabled auto-merge (squash) February 10, 2025 16:45
@avik-pal
Copy link
Contributor Author

We need EnzymeAD/Enzyme-JAX#332 else we get a missing symbols error from the enzymexla version bump

@giordano giordano disabled auto-merge February 10, 2025 17:02
@giordano
Copy link
Member

I'm going to cancel the existing jobs then.

@Pangoraw
Copy link
Contributor

Pangoraw commented Feb 10, 2025

@avik-pal I opened the pr to update this pr with the newer Reactant commit which accounts for the Enzyme-JAX fix (i.e. avik-pal#413).

@giordano
Copy link
Member

https://buildkite.com/julialang/yggdrasil/builds/17522#0194f197-c77e-4f99-8664-bb3d6d3ff712/6-20156

[22:44:00] ERROR: /workspace/bazel_root/097636303b1142f44508c1d8e3494e4b/external/enzyme_ad/src/enzyme_ad/jax/BUILD:373:11: Compiling src/enzyme_ad/jax/Dialect/Dialect.cpp failed: (Exit 1): aarch64-apple-darwin20-cc failed: error executing command (from target @enzyme_ad//src/enzyme_ad/jax:XLADerivatives) 
[...]
[22:44:00] In file included from external/enzyme_ad/src/enzyme_ad/jax/Dialect/Dialect.cpp:11:
[22:44:00] external/enzyme_ad/src/enzyme_ad/jax/Dialect/Ops.h:18:10: error: use of private header from outside its module: 'mlir/Interfaces/CallInterfaces.h' [-Wprivate-header]
[22:44:00]    18 | #include "mlir/Interfaces/CallInterfaces.h"
[22:44:00]       |          ^
[22:44:00] 1 error generated.

@avik-pal
Copy link
Contributor Author

cc @Pangoraw / @wsmoses ^

@wsmoses wsmoses enabled auto-merge (squash) February 11, 2025 03:29
@wsmoses wsmoses merged commit d3b0ceb into JuliaPackaging:master Feb 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants