Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Libevent] Rebuild for new platforms #10489

Merged
merged 2 commits into from
Feb 10, 2025
Merged

[Libevent] Rebuild for new platforms #10489

merged 2 commits into from
Feb 10, 2025

Conversation

ViralBShah
Copy link
Member

No description provided.

@ViralBShah ViralBShah changed the title [Libevent] Rebuild for riscv [Libevent] Rebuild for new platforms Feb 9, 2025
@eschnett
Copy link
Contributor

eschnett commented Feb 9, 2025

I assume you know how to build against OpenSSL these days; it requires special sauce... Look at rsync for inspiration if not.

@ViralBShah
Copy link
Member Author

ViralBShah commented Feb 10, 2025

The rsync build seems to filter out windows saying that we are unable to link openssl. Should we wait until then? Otherwise, we would add some platforms and lose some.

Ah and we don't have openssl on riscv in any case. So this won't get us much anyways.

@ViralBShah ViralBShah marked this pull request as draft February 10, 2025 14:37
@eschnett
Copy link
Contributor

If you want to build against OpenSSL on riscv64 then you need to use this dependency specification:

    Dependency(get_addable_spec("OpenSSL_jll", v"3.0.15+2"); compat="3.0.15"),

The get_addable_spec is important. You'll also need a

using BinaryBuilderBase: get_addable_spec

in the beginning of the build script.

The reason for these shenanigans is that the OpenSSL version number wasn't updated to 3.0.16 as we're doing for all other packages.

@ViralBShah
Copy link
Member Author

Seems like it all went through. I wish I hadn't merged the tmux. Presumably, tmux can just be retriggered to pick up everything since it already has the new JLLWrappers etc.

@giordano
Copy link
Member

Presumably, tmux can just be retriggered to pick up everything since it already has the new JLLWrappers etc.

Not without changing version number if it needs changing compat bounds (I haven't checked)

@ViralBShah ViralBShah marked this pull request as ready for review February 10, 2025 15:58
@ViralBShah
Copy link
Member Author

I just merged tmux earlier today (with a new version number), so I think it should have picked up all the new compat bounds. The new one should probably just pick up riscv binaries.

@ViralBShah
Copy link
Member Author

Does this look good to merge - especially the openssl stuff?

@eschnett
Copy link
Contributor

The PR looks good. I haven't looked at the build output, especially for riscv64 and aarch64-freebsd, to see whether there are important warnings.

@ViralBShah ViralBShah merged commit d029817 into master Feb 10, 2025
21 checks passed
@ViralBShah ViralBShah deleted the vs/libevent branch February 10, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants