-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLVM] Bump to v19.1.7+0 #10479
[LLVM] Bump to v19.1.7+0 #10479
Conversation
Also switch clang back to v16 for compilation as that seems to be faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also switch clang back to v16 for compilation as that seems to be faster.
Sigh.
L/LLVM/common.jl
Outdated
@@ -20,7 +20,7 @@ const llvm_tags = Dict( | |||
v"16.0.6" => "499f87882a4ba1837ec12a280478cf4cb0d2753d", # julia-16.0.6-2 | |||
v"17.0.6" => "0007e48608221f440dce2ea0d3e4f561fc10d3c6", # julia-17.0.6-5 | |||
v"18.1.7" => "ed30d043a240d06bb6e010a41086e75713156f4f", # julia-18.1.7-2 | |||
v"19.1.1" => "49c6812e2c4624a7f0cee34859a0511209f44b67", # julia-19.1.1-1 | |||
v"19.1.1" => "6e8ff5767e9466d73be85f1eaa760e2c94cdbd86", # julia-19.1.7-0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to self to create the tag if this is working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, tag created: https://github.com/JuliaLang/llvm-project/releases/tag/julia-19.1.7-0
How did you measure this? This wouldn't have involved ccache, would it? |
That's still relevant for the first run with cold cache, and for windows we always use clang and disable ccache: Lines 51 to 56 in 332689d
Lines 284 to 286 in 332689d
|
When binary builder added clang 17, my builds all started timing out (i.e taking hours longer) on the CI at https://github.com/Zentrik/llvm_julia_tester. I don't think I even had ccache setup then (I did also enable cache at windows at the same time, GitHub runners don't have enough threads to cause issues). Edit: also ccache provides little benefit when compiling head as there are too many commits on weekdays. |
@Zentrik are we good to build on JuliaLang/llvm-project@3cb75ba now (remember to bump the triggers to force rebuild for all platforms)? We should have reasonably warm ccache and multi-threaded auditor, hopefully this should save some time during the builds. |
Hopefully, I have a build going on at https://github.com/Zentrik/llvm_julia_tester/actions/runs/13227764722 to confirm. But if building here won't require much work from you feel free to kick it off/ I'll do it in a bit. |
Previous build, LLVM_full i686-linux-gnu-cxx11:
New build, LLVM_full i686-linux-gnu-cxx11:
Previous build, LLVM_full_assert riscv64-linux-gnu-cxx03
New build, LLVM_full_assert riscv64-linux-gnu-cxx03
Parallel audit is finally bearing fruits. |
Good to go once last job finishes? |
Yep 🥳 |
Well, I don't know if we'll ever get out of the race condition on
We hit it three times in a row in the remaining job... |
Also switch clang back to v16 for compilation as that seems to be faster.