Keep track of file permissions #32
Conversation
With this patch the file mode of files in relocatable folders are recorded when the file is originally read. When the underlying folder is removed and the contents are written to scratch space, the original file mode is set on the new files.
There was a problem hiding this comment.
A part of me wonders if we shouldn't rearchitect this package to use Tar.jl to import the files to be relocated, then use Tar.extract() to write it out. Our Tar package is kind of the defacto "data serialization format" that we use in Pkg, and so it handles all the permissions and directory traversal and whatnot issues that we will inevitably run into in this package. I'll open an issue about that so we can discuss it not in this PR.
| @@ -0,0 +1 @@ | |||
| This file is readonly. | |||
There was a problem hiding this comment.
Git doesn't track readonly permissions; it only tracks executable or not; you'll need to create a readonly file (or modify this one via chmod()) in order to properly test.
|
I don't think this is a good approach since file permissions can't really be relied upon (e.g. Pkg changes to read-only when installing etc). |
With this patch the file mode of files in relocatable folders are recorded when the file is originally read. When the underlying folder is removed and the contents are written to scratch space, the original file mode is set on the new files.
Opening as a draft because: i) I don't know (yet) how this interacts with packages that are
Pkg.added (the package manager makes all files read only) and ii) don't know what happens on Windows.